Remove old storagebox code (using hetzner_user) #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
storagebox-removal
branch
from
974862c to
fe60d91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 99.93% 99.92% -0.01%
==========================================
Files 61 61
Lines 4722 4103 -619
Branches 519 431 -88
==========================================
- Hits 4719 4100 -619
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felixfontein
force-pushed
the
storagebox-removal
branch
from
3c4a62e to
3eebb84
Compare
|
The last TODO item is blocked by ansible/ansible#85614; I might just move it to a follow-up PR and first get the others merged (and released). |
|
Hmm, according to https://robot.hetzner.com/doc/webservice/en.html#get-storagebox the old API is still there for some specific storage boxes. So let's wait with merging this until the API has been fully removed. |
felixfontein
force-pushed
the
storagebox-removal
branch
from
9f94fd7 to
b9d81d4
Compare
felixfontein
force-pushed
the
storagebox-removal
branch
3 times, most recently
from
476d8b4 to
19c39f8
Compare
felixfontein
force-pushed
the
storagebox-removal
branch
from
19c39f8 to
7585d2a
Compare
felixfontein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Deprecatemoved to Storagebox: deprecatehetzner_user/hetzner_pass;hetzner_tokenwill be required in the future;hetzner_user, deprecate compatibility shim return values #178Deprecate membership inmoved to Storagebox: deprecaterobotaction group;hetzner_user, deprecate compatibility shim return values #178Deprecate fake return values.moved to Storagebox: deprecatehetzner_user, deprecate compatibility shim return values #178ISSUE TYPE
COMPONENT NAME
storagebox* modules